AnimNotify_GameplayCue Looping #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fr0oZzFred
previously approved these changes
May 28, 2025
TheEmidee
reviewed
May 28, 2025
| UGameplayCueFunctionLibrary::AddGameplayCueOnActor( owning_actor, GameplayCueTag, Parameters ); | ||
| FGameplayCueParameters gameplay_cue_parameters; | ||
|
|
||
| if ( bUseLineTraceToFeelParameters ) |
There was a problem hiding this comment.
should be bLineTraceToFillParameters
There was a problem hiding this comment.
😮 I was filling there was a problem when I wrote this 
Done
TheEmidee
requested changes
May 28, 2025
| UPROPERTY( EditAnywhere, Category = "GameplayCue", meta = ( Categories = "GameplayCue", AllowPrivateAccess ) ) | ||
| FGameplayCueParameters Parameters; | ||
| UPROPERTY( EditAnywhere, Category = "Parameters", meta = ( AllowPrivateAccess ) ) | ||
| uint8 bUseLineTraceToFeelParameters : 1; |
There was a problem hiding this comment.
this can be a boolean, no need for a uint8 : 1 anymore. and should be initialized to false
TheEmidee
deleted the
anim_notify_gameplaycue_linetrace_parameters_from_linetrace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added opitons to AnimNotifyGameplayCue_looping class to be able to fill the gameplaycue parameters with a Line trace's hit result. ( most important here is the physical material, it is very usefull to manage the GC's surface restriction spawn condition )